Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSGi MANIFEST.MF is broken for version 0.95 #205

Open
Vogel612 opened this issue Aug 8, 2018 · 0 comments
Open

OSGi MANIFEST.MF is broken for version 0.95 #205

Vogel612 opened this issue Aug 8, 2018 · 0 comments

Comments

@Vogel612
Copy link

Vogel612 commented Aug 8, 2018

The MANIFEST.MF for version 0.95 contains the bnd-directive Export-Packages: {local-packages}. That directive is meaningless for the OSGi container that handles the package provision. Instead the Export-Package should contain a list of packages, as seen in #53

The MANIFEST I obtained from 0.95 itself is reproduced in full below:

Manifest-Version: 1.0
Bundle-SymbolicName: de.danielbechler.java-object-diff
Bundle-ManifestVersion: 2
Bnd-LastModified: 1516132378000
Bundle-Vendor: Daniel Bechler
Bundle-DocURL: https://github.com/SQiShER/java-object-diff
Import-Package: org.slf4j;version="[1.7,2)"
Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.5))"
Tool: Bnd-3.2.0.201605172007
Export-Package: {local-packages}
Bundle-Version: 0.95
Bundle-Name: java-object-diff
Private-Package: de.danielbechler.diff,de.danielbechler.diff.access,de
 .danielbechler.diff.category,de.danielbechler.diff.circular,de.daniel
 bechler.diff.comparison,de.danielbechler.diff.differ,de.danielbechler
 .diff.filtering,de.danielbechler.diff.identity,de.danielbechler.diff.
 inclusion,de.danielbechler.diff.instantiation,de.danielbechler.diff.i
 ntrospection,de.danielbechler.diff.node,de.danielbechler.diff.path,de
 .danielbechler.diff.selector,de.danielbechler.util
Created-By: 1.8.0_112 (Oracle Corporation)

I have not quite nailed down, where this error was introduced, but I assume it's to do with the following line in build.gradle:

instruction 'Export-Package', '{local-packages}'

Since build.gradle is already using the osgi-plugin a possible fix would be to just drop that specification, since (AFAICT) all packages are intended to be exported anyways.
Expect a PR that adresses this soon :)

Vogel612 added a commit to Vogel612/java-object-diff that referenced this issue Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant