You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Leak 75
Require implementation of function dlite_mapping_plugin_free().
See the comment on line 104 in src/dlite-mapping.c
Leak 93
To be investigated more.
Seems that Python is not calling the destructor for StorageIterator in bindings/python/dlite-storage.i.
When these issues are fixed, and cmake --build . --target memcheck runs without failure, consider to add a GitHub CI test running cmake --build . --target memcheck for selected Python versions and platforms. However, please note that the memory checking is very slow, so it should not be run too often. Maybe periodically or only when merging to master?
Is it possible to save the log files, Testing/Temporary/MemoryChecker.<#>.log, somewhere where they can be accessed for later inspection? Alternatively make the output verbose by removing the -q option to valgrind.
For debugging, use the following command to rerun the individual tests with valgrind:
Running
make memcheck
currently shows no memory errors and 3 memory leaks:Leak 60 is a duplicate of leak 73 and 93.
Leak 75
Require implementation of function dlite_mapping_plugin_free().
See the comment on line 104 in src/dlite-mapping.c
Leak 93
To be investigated more.
Seems that Python is not calling the destructor for StorageIterator in bindings/python/dlite-storage.i.
When these issues are fixed, and
cmake --build . --target memcheck
runs without failure, consider to add a GitHub CI test runningcmake --build . --target memcheck
for selected Python versions and platforms. However, please note that the memory checking is very slow, so it should not be run too often. Maybe periodically or only when merging to master?Is it possible to save the log files,
Testing/Temporary/MemoryChecker.<#>.log
, somewhere where they can be accessed for later inspection? Alternatively make the output verbose by removing the-q
option to valgrind.For debugging, use the following command to rerun the individual tests with valgrind:
The text was updated successfully, but these errors were encountered: