Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MP3 Encoder #2679

Open
eXpl0it3r opened this issue Sep 7, 2023 · 2 comments
Open

Implement MP3 Encoder #2679

eXpl0it3r opened this issue Sep 7, 2023 · 2 comments

Comments

@eXpl0it3r
Copy link
Member

With #1851 we implemented a MP3 decoder using minimp3, meaning you can open MP3 files and play them.

To fix the asymmetry, we should also implement a MP3 encoder, which allows to write MP3 files from a SFML sound buffer.

This issue has been create separately from #1232 to lower confusion between the more commonly understood "MP3 support", as in playing MP3 files, and feature symmetry, as in decoder & encoder.

@MarioLiebisch
Copy link
Member

Stumbled over this again. Is there any library qualifying for this? Both LAME and Shine are LGPL, so would require yet another dependency (possibly loaded at runtime only?).

@ChrisThrasher
Copy link
Member

Our one LGPL dependency OpenAL is a constant source of pain for users on Windows. I'd hope we can find a more permissively licensed option so that we can statically link it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants