Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDAnimatedImageView播放apng动画时,在iPhone 13 pro机型上太快,应该是因为手机是120Hz刷新频率导致的,希望修复 #3579

Closed
3 tasks
zifeizhang opened this issue Aug 2, 2023 · 7 comments · Fixed by #3644
Labels
help wanted Extra attention is needed promotion Bug related to Promotion 120Hz
Milestone

Comments

@zifeizhang
Copy link

New Issue Checklist

Issue Info

Info Value
Platform Name e.g. ios / macos / tvos / watchos
Platform Version e.g. 12.0 / 10.14.0 / 12.0 / 5.0
SDWebImage Version e.g. 5.0.0 / 4.4.0
Integration Method e.g. carthage / cocoapods / manually
Xcode Version e.g. Xcode 11 / Xcode 10
Repro rate e.g. all the time (100%) / sometimes x% / only once
Repro with our demo prj e.g. does it happen with our demo project?
Demo project link e.g. link to a demo project that highlights the issue

Issue Description and Steps

Please fill in the detailed description of the issue (full output of any stack trace, compiler error, ...) and the steps to reproduce the issue.

@zifeizhang zifeizhang changed the title SDAnimatedImageView播放apng动画 SDAnimatedImageView播放apng动画时,在iPhone 13 pro机型上太快,应该是因为手机是120Hz刷新频率导致的,希望修复 Aug 2, 2023
@dreampiggy
Copy link
Contributor

dreampiggy commented Aug 2, 2023

Provide your issue template. At least

Info Value
Platform Name e.g. ios / macos / tvos / watchos
Platform Version e.g. 12.0 / 10.14.0 / 12.0 / 5.0
SDWebImage Version e.g. 5.0.0 / 4.4.0

@zifeizhang
Copy link
Author

image

@zifeizhang
Copy link
Author

👆上面代码执行动画,设置时长没用,看了源码属性playbackRate 这个设置会有用;
1、在60Hz的手机上,使用默认playbackRate 这个值,动画正常播放;
2、在120Hz的手机上,速度感觉快了一倍的样子;
3、看了你的 SDDisplayLink 这个类,里面有 #define kSDDisplayLinkInterval 1.0 / 60 这个宏定义,猜测是否和这个有关

@zifeizhang
Copy link
Author

iOS 16系统,苹果13pro

@dreampiggy
Copy link
Contributor

dreampiggy commented Aug 3, 2023

Do you try to upgrade and test result again ?

SDWebImage Version | e.g. 5.0.0 / 4.4.0

@lyandy
Copy link

lyandy commented Oct 9, 2023

@zifeizhang I guess your issue is the same as #3280

ref: Optimizing ProMotion refresh rates for iPhone 13 Pro and iPad Pro

@dreampiggy
Copy link
Contributor

@lyandy @zifeizhang Can anyone with reproducable iPhone to debug and fire PR ? Maybe iPhone simulator can not reproduce this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed promotion Bug related to Promotion 120Hz
Projects
None yet
3 participants