Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request][DatePicker]: DatePicker should provide a way to set today value #10091

Open
1 task done
QiuranHu opened this issue Oct 28, 2024 · 5 comments
Open
1 task done

Comments

@QiuranHu
Copy link

Feature Request Description

Hi Team,
Our requirement is we need to select date in a specific time zone. In the screenshot, the time zone is UTC + 9.
So for DatePicker, the today value should not be today in browser time zone, but today in UTC + 9 (in this case today should be Oct 28, not 27).

Screenshot 2024-10-28 at 10 58 13

So now there is a bug in our page. Could you please enhance the API of DatePicker so the today value can be customized? Or provide an option to hide today value (the purple highlight)

I think there should be other teams with similar requirements inside SAP (select date in a different time zone than browser's). So this feature could benefit other teams as well

Proposed Solution

DatePicker should provide a way to set today value

Proposed Alternatives

DatePicker should provide an option to hide today value

Organization

SuccessFactors

Additional Context

No response

Priority

Medium

Privacy Policy

  • I’m not disclosing any internal or sensitive information.
@ilhan007
Copy link
Member

Hello @QiuranHu did you use the timezone setting to configure the timezone in question?

@QiuranHu
Copy link
Author

Hi @ilhan007, thanks for your quick reply!
Can I only apply this setting to part of the application? Because in other part of our application, we used UTC timezone.

Qiuran Hu

@ilhan007
Copy link
Member

Hi @QiuranHu

No, the timezone configuration is not per DatePicker instance, it's per UI5 Web Components runtime (with all date/time web components that are part of it), e.g the entire app or micro-frontend, etc.
In terms of its scope, timezone is the same as the theme and language settings.

The other part of the application that you mentioned, it is a micro-fronted with its own UI5 Web Components runtime, or both the picker in UTC and the picker in UTC+9 are in a single application (no microfrontends) that are using a single UI5 Web Components runtime?

@QiuranHu
Copy link
Author

Hi @ilhan007 ,
In my case, both the picker in UTC and the picker in UTC+9 are in a single application (no microfrontends) that are using a single UI5 Web Components runtime

@ilhan007
Copy link
Member

ilhan007 commented Oct 28, 2024

Hello @QiuranHu
I am not sure that hiding the "today" marker would be acceptable design-wise.

We can continue offline, but I would like to get a statement by your design team about the topic:
is it ok for your design team to have a date picker without today marker?

Overall, could you explain briefly what is the use-case of having date pickers in different timezones in the same page or app?

BR,
ilhan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants