Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-menu): make close event non-bubbling #10133

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Nov 4, 2024

Fixes: #10041

@ilhan007 ilhan007 changed the title refactor(ui5-menu): make close event non-bubbling fix(ui5-menu): make close event non-bubbling Nov 4, 2024
// .should("not.have.attr", "selected");

// cy.get("@items")
// .eq(3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to comment this? it is passing to me.

@@ -156,12 +176,26 @@ describe("Event bubbling", () => {

cy.get("@dialog")
.then(dialog => {
dialog.get(0).addEventListener("close", cy.stub().as("dialogClosed"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about naming the aliases and when they are linked to two different stubs. Can we rename one of them to dialogClosed2?

});

cy.get("@button")
.then(button => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is redundant since you call ui5Open later in the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ResponsivePopover] Popover close event is called when menu inside the popover is closed
2 participants