-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui5-menu): make close event non-bubbling #10133
base: main
Are you sure you want to change the base?
Conversation
// .should("not.have.attr", "selected"); | ||
|
||
// cy.get("@items") | ||
// .eq(3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to comment this? it is passing to me.
@@ -156,12 +176,26 @@ describe("Event bubbling", () => { | |||
|
|||
cy.get("@dialog") | |||
.then(dialog => { | |||
dialog.get(0).addEventListener("close", cy.stub().as("dialogClosed")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about naming the aliases and when they are linked to two different stubs. Can we rename one of them to dialogClosed2?
}); | ||
|
||
cy.get("@button") | ||
.then(button => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is redundant since you call ui5Open later in the test.
Fixes: #10041