Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit in the View Settings dialog #327

Open
skultetymichal opened this issue Jul 19, 2021 · 5 comments
Open

Limit in the View Settings dialog #327

skultetymichal opened this issue Jul 19, 2021 · 5 comments

Comments

@skultetymichal
Copy link

I have an issue regarding the View Settings dialog in UI5 apps:

I have an assertion to check number of records in View Settings dialog:

expect(settingsWindow.getAllPossibleFields().count()).toEqual(Constants.adaptTable.additionalColumns.length); //shoul be some number, in this case 66

getAllPossibleFields() {
    let xpath = '//td[@class="sapMListTblCell"]//bdi';

    return this.getAllByXPath(xpath);

In all of our apps no matter how many records in View Settings dialog there is, It seems the limit stored in the count() is always 25
image

@maximnaidenov
Copy link
Contributor

I can't comment what this XPath returns, can you please run it in browser control and confirm what number it would really give?

@skultetymichal
Copy link
Author

thank you Maxim for you reply I evaluated using following expression in the console
$x('//td[@Class="sapMListTblCell"]//bdi').length
and the result is 70
image

@maximnaidenov
Copy link
Contributor

Maybe this getAllByXPath adds another level of filtering, for example showing only visible items ?

@skultetymichal
Copy link
Author

skultetymichal commented Jul 19, 2021

I dont think that the issue is in the getAllByXPath

I use another function: it checks whether the column is present in the dialog, it loops the list of columns that should be there:

hasColumnsUnderSettings: function(columns) {
columns.forEach(column => {
expect(tableBuilderInstance.getAvailableColumnName(column).isPresent()).toBeTruthy('Column ' + column + ' is visible');
});

You can see that the resulting number of hits returned by XPATH is 1, and the column "WIP" is not visible in the screen
image

I normally use isDisplayed in the function, but when I use isPresent, as you can see in the code snippet, It is strange that the limit is reached eventhough isPresent checks just if the element is present in DOM

@hmanchev
Copy link
Contributor

hmanchev commented Apr 8, 2022

Is this issue still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants