Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SAP icons in editor or hover #512

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: SAP icons in editor or hover #512

wants to merge 1 commit into from

Conversation

uxkjaer
Copy link
Member

@uxkjaer uxkjaer commented Oct 21, 2022 •
edited
Loading

Todo:

  • Settings for showing icons in editor or only on hover
  • Setting to disable icon hover or editor
  • On hover functionality
  • Code completion for icons
  • Update readme with Icons functionality and prerequisite of SAP-icons fonts installed on machine
  • Make tests pass
  • Add integration tests

fixes #509

@uxkjaer uxkjaer added enhancement New feature or request help wanted Extra attention is needed labels Oct 21, 2022
@uxkjaer uxkjaer changed the title feat: icons in editor POC - failing tests feat: SAP icons in editor or hover Oct 21, 2022
@lgtm-com
Copy link

lgtm-com bot commented Oct 21, 2022

This pull request introduces 5 alerts when merging f4effa8 into 352164f - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class

@uxkjaer
Copy link
Member Author

uxkjaer commented Oct 21, 2022

Should the sap-icon font-family be added to the editor in the extension or should the user set it themselves in the settings?
@petermuessig @bd82

@cla-assistant
Copy link

cla-assistant bot commented Oct 18, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Oct 18, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@cla-assistant
Copy link

cla-assistant bot commented Oct 18, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code completion for SAP-icons
1 participant
@uxkjaer