Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate legacy method of setting NX CI Access Token #2518

Open
tobiashofmann opened this issue Oct 31, 2024 · 1 comment
Open

Evaluate legacy method of setting NX CI Access Token #2518

tobiashofmann opened this issue Oct 31, 2024 · 1 comment
Assignees

Comments

@tobiashofmann
Copy link

Seems that the NX CI access token is included in nx.json: https://github.com/SAP/open-ux-tools/blob/main/nx.json

"accessToken": "ZjFiYzA4OTYtYjFlNS00NTI2LTk4OTktNWZiYTAyMGE0ZGRmfHJlYWQtd3JpdGU=",

This is considered legacy by NX: https://nx.dev/ci/recipes/security/access-tokens

"We do not recommend that you commit an access token to your repository but older versions of Nx do support this"

Why not use secrets and put the token there? Seems that the token used in a read/write token:
f1bc0896-b1e5-4526-9899-5fba020a4ddf|read-write

The NX documentation cited above states additional recommendation for a read/write token.

In case the token is still used: why not follow the NX recommendations?
If not used: why not remove it?

@devinea
Copy link
Member

devinea commented Nov 1, 2024

Thanks. Investigating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants