Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docu link URL on compound configuration #3730

Merged
merged 7 commits into from
May 21, 2024

Conversation

Jotrorox
Copy link
Contributor

Description

Hey,
it's me again, I hope the change in the sentence structure is fine,
except that it is a tiny change, so hopefully the testing is working this time.

Kind Regards
Johannes

Changes proposed in this pull request:

  • Making one Link named and changing the sentence structure

Related issue(s)
Should Resolve #3729

@ndricimrr ndricimrr changed the title Adressing #3729 » Fix: Changing the sentence structure and fix the link Fix docu link URL on compound configuration May 17, 2024
@ndricimrr ndricimrr self-assigned this May 17, 2024
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Jotrorox ,

Thanks again for your contribution!

Left some small comments and suggestions.

docs/luigi-compound-container-api.md Outdated Show resolved Hide resolved
docs/luigi-compound-container-api.md Outdated Show resolved Hide resolved
Copy link
Contributor

@walmazacn walmazacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after adjustments

Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Thanks for your contribution.

@ndricimrr ndricimrr merged commit 84f47e7 into SAP:main May 21, 2024
11 checks passed
@JohannesDoberer JohannesDoberer added the documentation documentation tasks label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix link typo docu compound container long URL
4 participants