Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure container tests #3699

Merged
merged 143 commits into from
May 28, 2024
Merged

Restructure container tests #3699

merged 143 commits into from
May 28, 2024

Conversation

ndricimrr
Copy link
Contributor

@ndricimrr ndricimrr commented Apr 16, 2024

Description

Changes proposed in this pull request:

  • Restructure container tests to make it easier to write Cypress tests in the future.
  • Add ReadMe's to make it easier to understand structure
    ...

Follow-Up: There is a long list of features/API calls/etc that exist in the test-app now, which are not added to the Cypress test. This PR aims to add some structure and separate concerns (iframe/wc/compound) since they were all mixed up in one large file. Also to get rid of the tailwind dashboard. As a Follow Up may reorganize the the JS webcomponent files and html test files gradually as we continue to increase Container E2E Test Coverage.

Related issue(s)

Resolves #3562
Resolves #3720

@ndricimrr ndricimrr changed the title 3562 restructure container tests Restructure container tests Apr 17, 2024
@ndricimrr ndricimrr marked this pull request as ready for review April 17, 2024 14:37
@ndricimrr ndricimrr added the internal Stuff like NFRs, CI pipeline label Apr 24, 2024
@JohannesDoberer JohannesDoberer added the documentation documentation tasks label May 23, 2024
Copy link
Contributor

@walmazacn walmazacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I run tests locally and all of them are successful; same with localhost pages (2222 and 8080) - no errors in the console 🎉

@JohannesDoberer JohannesDoberer self-assigned this May 27, 2024
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

container/test-app/index.html Show resolved Hide resolved
@ndricimrr ndricimrr merged commit 9184dfe into main May 28, 2024
11 checks passed
@ndricimrr ndricimrr deleted the 3562-restructure-container-tests branch May 28, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation tasks internal Stuff like NFRs, CI pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Cypress Pipeline Record option for better debugging Restructure Container Integration Tests
4 participants