-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure container tests #3699
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndricimrr
changed the title
3562 restructure container tests
Restructure container tests
Apr 17, 2024
ndricimrr
requested review from
hardl,
JohannesDoberer,
VincentUllal and
smahati
as code owners
April 17, 2024 14:37
…gi into 3562-restructure-container-tests
walmazacn
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I run tests locally and all of them are successful; same with localhost pages (2222 and 8080) - no errors in the console 🎉
JohannesDoberer
approved these changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
...
Follow-Up: There is a long list of features/API calls/etc that exist in the test-app now, which are not added to the Cypress test. This PR aims to add some structure and separate concerns (iframe/wc/compound) since they were all mixed up in one large file. Also to get rid of the tailwind dashboard. As a Follow Up may reorganize the the JS webcomponent files and html test files gradually as we continue to increase Container E2E Test Coverage.
Related issue(s)
Resolves #3562
Resolves #3720