Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not applying defaultChecked prop for RadioItem #1352

Closed
wants to merge 3 commits into from
Closed

fix: not applying defaultChecked prop for RadioItem #1352

wants to merge 3 commits into from

Conversation

LucaFilitz
Copy link

Description

This line of code passes the defaultChecked prop to the input item which is required so that the prop actually has an effect.

fixes #1351

@CLAassistant
Copy link

CLAassistant commented Aug 6, 2021

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Aug 6, 2021

✔️ Deploy Preview for fundamental-react ready!

🔨 Explore the source changes: c9f8887

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-react/deploys/61292970acfd96000740c231

😎 Browse the preview: https://deploy-preview-1352--fundamental-react.netlify.app

Copy link
Contributor

@droshev droshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would need to rename your commit message respecting conventional commits

moving react import to line one to have some change for the new commit message
Copy link
Author

@LucaFilitz LucaFilitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommited with a different commit message

@LucaFilitz
Copy link
Author

Is there any update on this?

@github-actions
Copy link

github-actions bot commented Oct 3, 2021

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale label Oct 3, 2021
@github-actions github-actions bot closed this Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RadioItem not applying defaultChecked prop
3 participants