-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amend React docs and showcases by colon (:) for Input Form #1288
Comments
mengbingguo
changed the title
Input Label - No colon (:) automatically inserted at the end
Form Input Label - No colon (:) automatically inserted at the end
Jan 8, 2021
mengbingguo
changed the title
Form Input Label - No colon (:) automatically inserted at the end
Amend React docs and showcases by colon (:) for Input Form
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Having a colon is mandatory in the Fiori Guidelines (SAPUI5 renders that automatically), in the Fundamental React docs it's rather displayed as an additional case and not the default.
I think we should make it Fiori-compliant, showcases need to have colon in input label by default.
Reproduction
SAPUI5:
Fundamental React:
Reference
Fiori Guidelines: https://experience.sap.com/fiori-design-web/form/#guidelines
Fundamental React Docs: https://sap.github.io/fundamental-react/iframe.html?id=component-api-forms-formlabel--primary&viewMode=docs#include-colon
The text was updated successfully, but these errors were encountered: