Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend React docs and showcases by colon (:) for Input Form #1288

Open
mengbingguo opened this issue Jan 8, 2021 · 0 comments
Open

Amend React docs and showcases by colon (:) for Input Form #1288

mengbingguo opened this issue Jan 8, 2021 · 0 comments

Comments

@mengbingguo
Copy link

mengbingguo commented Jan 8, 2021

Description

Having a colon is mandatory in the Fiori Guidelines (SAPUI5 renders that automatically), in the Fundamental React docs it's rather displayed as an additional case and not the default.

I think we should make it Fiori-compliant, showcases need to have colon in input label by default.

Reproduction

SAPUI5:
image

Fundamental React:
image

Reference

Fiori Guidelines: https://experience.sap.com/fiori-design-web/form/#guidelines

At the end of the label, the form container automatically inserts a colon (:), which is triggered by the stylesheet. Do not write the colon manually in the label text.

Fundamental React Docs: https://sap.github.io/fundamental-react/iframe.html?id=component-api-forms-formlabel--primary&viewMode=docs#include-colon

@mengbingguo mengbingguo changed the title Input Label - No colon (:) automatically inserted at the end Form Input Label - No colon (:) automatically inserted at the end Jan 8, 2021
@mengbingguo mengbingguo changed the title Form Input Label - No colon (:) automatically inserted at the end Amend React docs and showcases by colon (:) for Input Form Jan 8, 2021
@mengbingguo mengbingguo reopened this Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant