Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Rule "Use String Templates to assemble Text" can not handle line breaks #306

Closed
fmabap opened this issue May 24, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@fmabap
Copy link

fmabap commented May 24, 2024

Hi,

we found a bug, that the ABAP Cleaner uglifies this statement:

image

It looks like, that it can not handle the line breaks.

We have version v1.16.1. of the ABAP Cleaner.
In the test profile is only the rule "Use String Templates to assemble Text" active with default settings:

image

We restrict the rule syntax to ABAP 7.50. But the issue occurs also with the latest ABAP release.

Here is the test code

  METHOD test.
    DATA lv_ts    TYPE char26.
    DATA lv_date  TYPE date.
    DATA lv_time  TYPE sy-uzeit.
    DATA lv_char6 TYPE char6.

    lv_char6 = '000000'.
    lv_date = sy-datum.
    lv_time = sy-uzeit.

    lv_ts = lv_date+0(4) && '-' &&
        lv_date+4(2) && '-' &&
        lv_date+6(2) && '-' &&
        lv_time+0(2) && '.' &&
        lv_time+2(2) && '.' &&
        lv_time+4(2) && '.' &&
        lv_char6(6).
  
    WRITE lv_ts.
  ENDMETHOD.

Can you please fix it?

Best regrads
Frank

@jmgrassau jmgrassau added the bug Something isn't working label May 29, 2024
@jmgrassau jmgrassau self-assigned this May 29, 2024
@jmgrassau
Copy link
Member

Hi Frank,

thanks for reporting this bug! It should be fixed with the next release:

image

Kind regards,
Jörg-Michael

@jmgrassau
Copy link
Member

Hi Frank,

thanks again for opening this issue – this should now be fixed with version 1.16.2, which was just released.

Kind regards,
Jörg-Michael

@fmabap
Copy link
Author

fmabap commented Jun 3, 2024

Hi Frank,

thanks again for opening this issue – this should now be fixed with version 1.16.2, which was just released.

Kind regards, Jörg-Michael

Hi Jörg-Michael,

thank you for the quick fix.

Kind regards
Frank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants