Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Cleanup tfvars #113

Closed
1 task done
lechnerc77 opened this issue Mar 7, 2024 · 1 comment
Closed
1 task done

[BUG] Cleanup tfvars #113

lechnerc77 opened this issue Mar 7, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@lechnerc77
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

What type of issue are you facing

bug report

Describe the bug

  • Add *.tfvars to .gitignore to follow best practices. Otherwise customers might by accidentally committed
  • Adjust code of samples
  • Adjust documentation of samples

Expected Behavior

n/a

Steps To Reproduce

n/a

Add screenshots to help explain your problem

n/a

Additional context

n/a

@lechnerc77 lechnerc77 added the bug Something isn't working label Mar 7, 2024
@prajin-op
Copy link
Contributor

PR #157 fixes the following.

  • Adjust code of samples
  • Adjust documentation of samples
  • Add *.tfvars to .gitignore (It is already part of .gitignore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants