-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
num-bigint-dig dependency #342
Comments
It would be nice to be able to migrate to The main reason why we can't do that today is We recently added some very much preliminary support for that in the form of Ideally we could allow heapless |
What about switching to standard I realize that I guess I'm just not familiar enough with what problems |
If it's possible to do so with a small change it's something we could consider. I too am not super familiar with what is preventing I'd still propose an eventual migration to |
When I forked, both speed and a series of algorithms needed for RSA were missing from I don't think it makes sense to migrate to anything other than |
Also note, the issue around |
Seems reasonable to me. Is |
@darconeous if you mean arbitrary precision like |
I'll go ahead and close this, reopen if you want to use it to track migration to |
#51 is probably the best tracking issue for See this comment: #51 (comment) |
num-bigint-dig
(used here) seems like a a suboptimal dependency. It doesn't appear to be actively developed and it has a few bugs related to prime number calculation that don't appear to be going away any time soon. There also doesn't appear to be any effort to upstream the changes intonum-bigint
.The bugs in the prime number calculation appear to be causing primes to be skipped (rather than non-primes being marked as prime), but the presence of these bugs doesn't inspire a lot of confidence.
The text was updated successfully, but these errors were encountered: