Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to netcore 2.0 #43

Open
Ruhrpottpatriot opened this issue Sep 22, 2017 · 0 comments
Open

Migrate to netcore 2.0 #43

Ruhrpottpatriot opened this issue Sep 22, 2017 · 0 comments
Milestone

Comments

@Ruhrpottpatriot
Copy link
Owner

Ruhrpottpatriot commented Sep 22, 2017

Since netcore has matured quite abit and PCL have become deprecated we should migrate our code to netcore where possible. Currently this requires a lot of handwork, but should be done as soon as possible.

To migrate a PCL project completely to netcore (i.e. netcoreapp2.0 and new .csproj file format) do the following steps:

  1. Unload the project and open the *.csproj file.
  2. Replace the content of the file with the following content:
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>netcoreapp2.0</TargetFramework>
    <RootNamespace>GW2NET</RootNamespace><!-- Change root namespace as required -->
  </PropertyGroup>
  <ItemGroup>
    <None Remove="stylecop.json" />
  </ItemGroup>
  <ItemGroup>
    <AdditionalFiles Include="$(SolutionDir)stylecop.json" />
  </ItemGroup>
</Project>
  1. Reinstall all missing NuGet packages again. Always install Stylecop.Analyzers.
  2. Delete the packages.config and project.json file and AssemblyInfo.cs
  3. Fix the remaining errors, so the code compiles again.

I'm currently looking into a way to add the global stylecop analyzers file suited for our needs. When I find something, I'll update this issue.

Additional Information:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant