Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'GetChatLink()' with a pregenerated string #24

Open
sliekens opened this issue Oct 15, 2015 · 0 comments
Open

Replace 'GetChatLink()' with a pregenerated string #24

sliekens opened this issue Oct 15, 2015 · 0 comments
Milestone

Comments

@sliekens
Copy link
Collaborator

/v2/items now has a chat_link field.

We already supported chat links in the form of Item.GetChatLink() : ItemChatLink. It would be appropriate to remove the GetChatLink() method and replace it with a ChatLink text property.

For /v1/item_details.json, the V1 item converters can be updated to generate the missing chat link.

We should probably do the same thing for recipes and POI chat links while we're at it.

@Ruhrpottpatriot Ruhrpottpatriot added this to the v2.0.0 milestone Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants