Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guild Emblems #13

Open
SamHurne opened this issue Sep 19, 2015 · 5 comments
Open

Guild Emblems #13

SamHurne opened this issue Sep 19, 2015 · 5 comments

Comments

@SamHurne
Copy link
Collaborator

[Moved from Codeplex: https://gw2dotnet.codeplex.com/workitem/1221]

We have a way to retrieve RGB color information, but we do not have a way to retrieve guild emblem icons. I know that the wiki has a complete gallery of emblems, but it's not clear if we are able/allowed to use that.

http://wiki.guildwars2.com/wiki/Gallery_of_guild_emblems

Also relevant: https://forum-en.guildwars2.com/forum/community/api/Use-of-Guild-Emblems

What can we do about this?

@Ruhrpottpatriot
Copy link
Owner

I have a small Wiki parser written. I'll have to write some more UnitTests for it, but then I'll upload it as a new branch here.

@sliekens
Copy link
Collaborator

I don't believe that scraping the wiki is the right way to go. Why not just store the images offline?

@Ruhrpottpatriot
Copy link
Owner

You have to get the images at some point and that is the reason for the parser. After that we should store them offline and requery when a new build gets released.

@sliekens
Copy link
Collaborator

Oh, I didn't think of it that way. In that case I think it's fine if it stays in a separate repository. It doesn't need to be in this one. Especially if you want to add a wiki for it.

@Ruhrpottpatriot
Copy link
Owner

For now it's in a separate repository. Handling a small at this point is less hassle. I'll move it to the main GW2.NET Solution when it's done. At that point the library will also include the link header parser mentioned in #11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants