Patch hfs-compression.diff errors

[TonyTTTT]

Patch hfs-compression.diff errors
macOS 10.15.6

attrs.c:274:1: error: unknown type name '$$$ERROR$$$'
$$$ERROR$$$ the old patch needs reworking since rsync_xal_get() has tota...
^
xattrs.c:274:16: error: expected ';' after top level declarator
$$$ERROR$$$ the old patch needs reworking since rsync_xal_get() has tota...
^
;
xattrs.c:1365:2: error: #endif without #if

[WayneD]

Yup, nobody with a Mac has submitted any fixes yet. I've had one person suggest that they might supply some, but no word yet. I'll just be removing it if it doesn't get some changes before too long.

[TonyTTTT]

With APFS, I don't need it, so just I compiled without the patch.
(IIRC. Mike Bombitch originally wrote the patch for his CCCloner program)
I'll send Mike an email, maybe he'll send in a fix.

[emclain]

$$$ERROR$$$ the old patch needs reworking since rsync_xal_get() has totally changed!

I was looking at this and I'm kind of puzzled by this comment. Looking at the blame for xattrs.c, I don't see any drastic changes to rsync_xal_get(). Or is it this change? 6eb71be

Do you know what concern this comment was referring to?

[emclain]

There is a stray #endif in the patch, but once that's removed it applies and builds cleanly. (Whether it works... is another question).

[WayneD]

Note that rsync patches is best discussed on the rsync-patches project, which has a bug open on this issue.
RsyncProject/rsync-patches#1