Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to webpack #167

Open
Sothatsit opened this issue May 5, 2021 · 0 comments
Open

Switch to webpack #167

Sothatsit opened this issue May 5, 2021 · 0 comments
Labels
feature A new feature to be added

Comments

@Sothatsit
Copy link
Collaborator

I think we should switch to using webpack (https://webpack.js.org/) for building the JavaScript (and potentially other aspects) of our codebase. Webpack allows us to just use import statements within the JavaScript, instead of relying on manually entering a list of files to concatenate in compilation.json.

This change poses some problems however:

  1. Webpack does not support JavaScript that is not written using modules. All of our JavaScript is not using modules. This means we have to change all of our JavaScript to use modules in order to support webpack... this is a big change. In the long term I do think this change is worthwhile, but it is going to be a difficult change to make.
  2. We still need to replace [ver] tags in our JavaScript. This will probably require keeping compile.py, and perhaps making it work with webpack.

I think this change will be worthwhile, but it is a huge undertaking. I'm still not sure of a good way to gradually make this change, as there is no way I can do it all at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature to be added
Projects
None yet
Development

No branches or pull requests

1 participant