Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT Token #48

Open
alesinicio opened this issue Jul 4, 2020 · 2 comments
Open

JWT Token #48

alesinicio opened this issue Jul 4, 2020 · 2 comments

Comments

@alesinicio
Copy link

Nowhere in the documentation you tell exactly how to send the JWT for authentication.
Digging the code, it looks like an "Authorization" header is expected in the GET request. Is that correct?
Also, just to clarify, you don't perform any kind of payload validation on the JWT, there is a simple hash validation, right?

@Roverr
Copy link
Owner

Roverr commented Jul 20, 2020

Hi @alesinicio ,

Thanks for opening this issue!

Your concern is fair, it is not properly described how you should use the system with JWT.
Of course now you know, that it is the standard Authorization: Bearer {token} but this should be described.

On your second question yes, it is a simple hash validation. I was thinking in implementing some kind of a payload validation but did not come up with a solution because at that point the service is trading flexibility for security while also introducing more complexity in integration. However, this is a topic I would like to take a deeper look once I have more time.

@alesinicio
Copy link
Author

alesinicio commented Jul 20, 2020

Thanks for the feedback!

As a suggestion for the hash validation, maybe you could check the existence of a fixed-name bash script (or python, or whatever seems the most widely adopted) on a specific directory. If the script exists, the token is passed to it for validation. If not, you fallback to the simple hash validation.

The script would obviously be provided by the user via a docker volume, thus retaining full flexibility (works like an user-provided extension).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants