Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes automatization #66

Open
DenTray opened this issue Nov 4, 2022 · 6 comments
Open

Release notes automatization #66

DenTray opened this issue Nov 4, 2022 · 6 comments
Assignees
Milestone

Comments

@DenTray
Copy link
Collaborator

DenTray commented Nov 4, 2022

It would be very helpfull to have an abulity to see chnages list between the each documentations change.

On each save documentation - we may set some version to the new documentation file and save the difference to the version.

We also need to find a way how to display these changes.

@vitgrams vitgrams self-assigned this Feb 28, 2023
@vitgrams
Copy link
Contributor

vitgrams commented Mar 20, 2023

@DenTray I have done research on this issue. We can rewrite the code of this library in php to get a difference between the documentation versions for Swagger (v1, v2). There is also a version of this library for Open API Specification (v3), also written in Java.
I also found a very useful plugin for the Phpstorm IDE and Visual Studio, which automatically shows the difference after selecting two versions of the documentation. There is one significant drawback of the tool. It cannot compare the description property of parameters. If the validation rules for a specific parameter change (except for the required rule), then we will not see this in the report.

@DenTray
Copy link
Collaborator Author

DenTray commented Mar 21, 2023

@vitgrams great thanks for your investigation! About the generating file of the doc difference, could you please generate some example using the Java library? For this please make the following:

  1. Generate documentation using Laravel swagger package with at least 2 API.
  2. Make the next changes in the API:
  • Remove 1 of existed API
  • Create at least 1 new API
  • Change the API's response code, and input body params by adding new input, removing existed input and updating rules for some of input fields
  1. Generate updated documentation file
  2. Generate the difference from the documentation files.

After finish with the example file - please try to find some free templates which can display the changes in the browser. I believe that IDE plugins are good but it will works only for developers team and force to install some additional tools which are not the best solution.

@DenTray DenTray removed their assignment Mar 21, 2023
@vitgrams
Copy link
Contributor

vitgrams commented Mar 27, 2023

@DenTray Generated documentation diff for two API versions. The results have been attached. Could you please take a look?
swagger-diff.zip

@DenTray
Copy link
Collaborator Author

DenTray commented Mar 28, 2023

@vitgrams thanks a lot! I believe such view is enought. Let's port java code to the php inside the Laravel-Swagger package

@DenTray
Copy link
Collaborator Author

DenTray commented Oct 4, 2023

@vitgrams we need to do the following

  1. On each documentation saving - check difference between the last version
  2. If changes not empty - increase doc version and save new documentation with changes from the last doc
  3. I believe we can store doc in the DB with fields: version, documentation, changes
  4. Implement separate route to view the list of documentations and changes

@DenTray DenTray added this to the 3.0 milestone Nov 7, 2023
@vitgrams
Copy link
Contributor

vitgrams commented Nov 7, 2023

@DenTray Branch 66_implement_swagger_diff_module with related changes has been pushed to remote as discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants