Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Endpoint: Create List of Users #237

Open
RohanNagar opened this issue Aug 4, 2018 · 0 comments
Open

New Endpoint: Create List of Users #237

RohanNagar opened this issue Aug 4, 2018 · 0 comments
Labels
P3 Low priority. No set deadline to address. Size: Medium The work involved in addressing this issue is a sizable amount. 1-2 days of work. Status: Available Work on this issue has not yet started and is available to be worked on. Type: Feature Addresses adding a new feature to the application.
Milestone

Comments

@RohanNagar
Copy link
Owner

RohanNagar commented Aug 4, 2018

Describe the problem that this feature would solve

Right now you can POST to /users with a single User. You should also be able to POST to /users with a list of users to create. Thunder should then issue a batch create request to the database with those users.

Describe the solution you'd like

A new endpoint in the UserResource that is very similar to the current POST /users, but takes in a list of users.
The method should call into the UsersDao with that list of users, and the UsersDao should do a batch create.

Additional context

For Dynamo: Will probably have to do a batch get, check for existing primary keys, and then do the batch update. Dynamo doesn't support conditional put with batch requests

Questions:

  • What do to if one of the user creations fail? Don't store any the DB or keep the ones that succeed? Maybe make that an optional query parameter?
@RohanNagar RohanNagar added Type: Feature Addresses adding a new feature to the application. P3 Low priority. No set deadline to address. Status: Available Work on this issue has not yet started and is available to be worked on. Size: Medium The work involved in addressing this issue is a sizable amount. 1-2 days of work. labels Aug 4, 2018
@RohanNagar RohanNagar added this to the v2.2.0 milestone Aug 4, 2018
@RohanNagar RohanNagar modified the milestones: v2.2.0, v2.4.0 Aug 31, 2018
@RohanNagar RohanNagar modified the milestones: v2.4.0, v2.3.0 Feb 15, 2019
@RohanNagar RohanNagar modified the milestones: v2.3.0, v3.1.0 May 27, 2020
@RohanNagar RohanNagar modified the milestones: v3.1.0, v3.2.0 Apr 30, 2021
@RohanNagar RohanNagar modified the milestones: v3.2.0, v3.3.0 Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low priority. No set deadline to address. Size: Medium The work involved in addressing this issue is a sizable amount. 1-2 days of work. Status: Available Work on this issue has not yet started and is available to be worked on. Type: Feature Addresses adding a new feature to the application.
Projects
None yet
Development

No branches or pull requests

1 participant