Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad tags kill eups distrib install #109

Open
ktlim opened this issue Dec 22, 2016 · 1 comment
Open

Bad tags kill eups distrib install #109

ktlim opened this issue Dec 22, 2016 · 1 comment

Comments

@ktlim
Copy link
Contributor

ktlim commented Dec 22, 2016

A tag that contains certain regexp metacharacters, including "+", will cause failures to recognize the .list file from the server. The problem is in

mat = re.search(r"^EUPS distribution %s version list. Version (\S+)\s*$" % self.tag, line)
which substitutes the tag name without any escaping before doing a regexp match.

@timj
Copy link
Collaborator

timj commented Sep 21, 2017

Looks like using re.escape(self.tag) would be enough. I wonder if there are other places that need that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants