Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Health: AlbumRipper is deprecated - only 2 usages of this class remain #2052

Open
metaprime opened this issue Jan 2, 2025 · 0 comments

Comments

@metaprime
Copy link
Contributor

  • Ripme version: main, 2.1.13+1

  • Java version: openjdk 21.0.5 2024-10-15
    OpenJDK Runtime Environment (build 21.0.5+11-Ubuntu-1ubuntu124.04)
    OpenJDK 64-Bit Server VM (build 21.0.5+11-Ubuntu-1ubuntu124.04, mixed mode, sharing)

  • Operating system: WSL2 Ubuntu 24.04

  • Exact URL you were trying to rip when the problem occurred: N/A

  • Please include any additional information about how to reproduce the problem:

./gradlew clean
./gradlew test

Expected Behavior

No warnings

Actual Behavior

ripme/src/main/java/com/rarchives/ripme/ripper/rippers/TumblrRipper.java:24: warning: [deprecation] AlbumRipper in com.rarchives.ripme.ripper has been deprecated
public class TumblrRipper extends AlbumRipper {
                                  ^
ripme/src/main/java/com/rarchives/ripme/ripper/rippers/RedditRipper.java:34: warning: [deprecation] AlbumRipper in com.rarchives.ripme.ripper has been deprecated
public class RedditRipper extends AlbumRipper {
                                  ^
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant