You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Exact URL you were trying to rip when the problem occurred:
Please include any additional information about how to reproduce the problem:
Expected Behavior
Ripme ends the current rip after finding 5 items it already downloaded (assuming history.end_rip_after_already_seen is set to 5)
Actual Behavior
Ripme only ends the current rip if remember.url_history is set to true. This is because history.end_rip_after_already_seen checks the alreadyDownloadedUrls var and alreadyDownloadedUrls is only incremented in the following if
// Don't re-add the url if it was downloaded in a previous ripif (Utils.getConfigBoolean("remember.url_history", true) && !isThisATest()) {
if (hasDownloadedURL(url.toExternalForm())) {
sendUpdate(STATUS.DOWNLOAD_WARN, "Already downloaded " + url.toExternalForm());
alreadyDownloadedUrls += 1;
returnfalse;
}
}
Another check should be added in DownloadFileThread.java. Something like
if (saveAs.exists() && !observer.tryResumeDownload()) {
alreadyDownloadedUrls += 1
}
The text was updated successfully, but these errors were encountered:
Expected Behavior
Ripme ends the current rip after finding 5 items it already downloaded (assuming history.end_rip_after_already_seen is set to 5)
Actual Behavior
Ripme only ends the current rip if remember.url_history is set to true. This is because history.end_rip_after_already_seen checks the
alreadyDownloadedUrls
var andalreadyDownloadedUrls
is only incremented in the followingif
Another check should be added in DownloadFileThread.java. Something like
The text was updated successfully, but these errors were encountered: