Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

プレビュー画像の読み込み速度を改善する #56

Open
RiniaOkyama opened this issue Dec 17, 2022 · 0 comments
Open

プレビュー画像の読み込み速度を改善する #56

RiniaOkyama opened this issue Dec 17, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@RiniaOkyama
Copy link
Owner

概要

image

ここの読み込み速度がゲロ遅い。

改善方法

まず画像を何故か同期的にfetchしているのを非同期にする

MarinDeck4iOS/Marindeck/Extensions/UIImage+URL.swift

Line 19 in a7e5fa9

let data = try Data(contentsOf: url)

非同期になることでここの処理も早くなるはず。

MarinDeck4iOS/Marindeck/View/Core/ViewController+Transition.swift

Line 159 in a7e5fa9

let imgs = imgUrls.compactMap({

RiniaOkyama added a commit that referenced this issue Dec 21, 2022
@RiniaOkyama
UIImage+URLを非同期にした #56
9161dcb
@RiniaOkyama RiniaOkyama added duplicate This issue or pull request already exists enhancement New feature or request and removed duplicate This issue or pull request already exists labels Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RiniaOkyama