Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image tinting to use UIGraphicsImageRenderer where possible #342

Open
ZevEisenberg opened this issue Jun 13, 2018 · 2 comments
Open

Comments

@ZevEisenberg
Copy link
Collaborator

UIGraphicsImageRenderer supports wide color, and UIGraphicsBeginImageContext does not. We should use the former on OSes that support it.

Questions:

  • does macOS have an equivalent image renderer?
  • We currently have a convoluted image tinting function with a lot of conditional compilation. Can we imrprove this situation? Will we need to, in order to add a third or possibly fourth permutation of how we render?
@shaps80
Copy link

shaps80 commented Jun 29, 2018

Hi,

I've actually been using your library for a while now. Great work btw.

I came across this Issue and thought you might be interested in my port:
https://github.com/shaps80/GraphicsRenderer

It's backward compatible & supports macOS. I don't think I've updated it to support wide colour, but that shouldn't be a huge task. Its also been designed to map the APIs directly, I was originally using it and then just dropping the prefix once I no longer needed it.

Anyway, maybe it's useful as a starting point.

@ZevEisenberg
Copy link
Collaborator Author

@shaps80 thanks for sharing! I'll check it out if/when I get around to implementing this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants