-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of PurchasesType
inside PurchasesDelegate
to allow mocking
#3039
Comments
👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out! |
Thanks for the suggestion @AvdLee. It would indeed make it a lot easier. Unfortunately We also can't even provide an We'll leave this issue open for our next upcoming major release though, so we can tackle this at the same time as when we drop support for iOS 11. |
Just wondering if this is something you're considering tackling for the upcoming 5.0 release? :) |
Right now, delegate methods are defined using the strongly typed
Purchases
. Therefore, we have to callPurchases.configure
in case we want to write tests for methods like:Instead, if the above delegate method would've been defined as:
We could create a mocked
PurchasesType
to use in our tests. I can see this as another great improvement similar to the TestProducts release.The text was updated successfully, but these errors were encountered: