Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUA] Some settings not correctly working in multiplayer #1660

Open
Spikeone opened this issue Apr 22, 2024 · 0 comments · May be fixed by #1663
Open

[LUA] Some settings not correctly working in multiplayer #1660

Spikeone opened this issue Apr 22, 2024 · 0 comments · May be fixed by #1663

Comments

@Spikeone
Copy link
Member

Using this setting:

function getAllowedChanges()
    return  {
        ["general"]     = true,
        ["addonsAll"]   = false,
        ["addonsSome"]  = true,
        ["ownNation"]   = true,
        ["ownColor"]    = true,
        ["ownTeam"]     = false,
        ["aiNation"]    = false,
        ["aiColor"]     = true,
        ["aiTeam"]      = false,
        ["swapping"]    = true,
        ["playerState"] = false,
        ["aiNation"]    = false
    }
end

does work fine for the host player in multiplayer - sadly the ownTeam seems to not affect any other player than the host. Same goes for the

function isMapPreviewEnabled()
    return false;
end

which works fine for the host - but no client.

grafik

Flamefire added a commit to Flamefire/s25client that referenced this issue May 16, 2024
The lua script was only loaded for the host as many function are
intended for the host, especially the lobbyController.
Load for all players and guard relevant parts for the host only.

Fixes Return-To-The-Roots#1660
@Flamefire Flamefire linked a pull request May 16, 2024 that will close this issue
Flamefire added a commit to Flamefire/s25client that referenced this issue May 23, 2024
The lua script was only loaded for the host as many function are
intended for the host, especially the lobbyController.
Load for all players and guard relevant parts for the host only.

Fixes Return-To-The-Roots#1660
Flamefire added a commit to Flamefire/s25client that referenced this issue May 29, 2024
The lua script was only loaded for the host as many function are
intended for the host, especially the lobbyController.
Load for all players and guard relevant parts for the host only.

Fixes Return-To-The-Roots#1660
Flamefire added a commit to Flamefire/s25client that referenced this issue May 31, 2024
The lua script was only loaded for the host as many function are
intended for the host, especially the lobbyController.
Load for all players and guard relevant parts for the host only.

Fixes Return-To-The-Roots#1660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant