Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix migration #2

Conversation

chrisguida
Copy link

@chrisguida chrisguida commented Feb 14, 2024

The migration was messed up in two ways:

  • technically v2transport doesn't exist yet and that will screw up trying to upgrade and downgrade with normal bitcoin core (switching back and forth between knots and core will probably always be awkward until support for two different packages with the same name is supported upstream)
  • datacarrier, datacarriersize, and permitbaremultisig weren't being initialized, resulting in this message upon installation:

Screenshot from 2024-02-14 14-50-25

This PR fixes both issues.

@Retropex Retropex self-assigned this Feb 14, 2024
@Retropex Retropex added the bug Something isn't working label Feb 14, 2024
@Retropex Retropex force-pushed the knots-for-community branch 2 times, most recently from 1f6c25e to d1c38f4 Compare March 28, 2024 17:31
@Retropex
Copy link
Owner

rebased and fixed in this commit d1c38f4
Thanks Chris!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants