Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move maxmempoolback to advanced #10

Merged
merged 3 commits into from
Oct 15, 2024
Merged

move maxmempoolback to advanced #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83dba5c
move maxmempoolback to advanced
BitcoinMechanic Oct 14, 2024
caf1844
oops
BitcoinMechanic Oct 14, 2024
c6a0e56
fix conf template
BitcoinMechanic Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/compat/bitcoin.conf.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ persistmempool=1
{{#IF !blkconstr.persistmempool
persistmempool=0
}}
maxmempool={{blkconstr.maxmempool}}
maxmempool={{advanced.mempool.maxmempool}}
mempoolexpiry={{blkconstr.mempoolexpiry}}

## PEERS
Expand Down
40 changes: 29 additions & 11 deletions scripts/services/getConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,17 +68,17 @@ export const getConfig: T.ExpectedExports.getConfig = async (effects) => {
description: "Save the mempool on shutdown and load on restart.",
default: true,
},
maxmempool: {
type: "number",
nullable: false,
name: "Max Mempool Size",
description:
"Keep the transaction memory pool below <n> megabytes.",
range: "[1,*)",
integral: true,
units: "MiB",
default: 300,
},
// maxmempool: {
// type: "number",
// nullable: false,
// name: "Max Mempool Size",
// description:
// "Keep the transaction memory pool below <n> megabytes.",
// range: "[1,*)",
// integral: true,
// units: "MiB",
// default: 300,
// },
mempoolexpiry: {
type: "number",
nullable: false,
Expand Down Expand Up @@ -365,6 +365,24 @@ export const getConfig: T.ExpectedExports.getConfig = async (effects) => {
name: "Advanced",
description: "Advanced Settings",
spec: {
mempool: {
type: "object",
name: "Mempool",
description: "Mempool Settings",
spec: {
maxmempool: {
type: "number",
nullable: false,
name: "Max Mempool Size",
description:
"Keep the transaction memory pool below <n> megabytes.",
range: "[1,*)",
integral: true,
units: "MiB",
default: 300,
},
},
},
peers: {
type: "object",
name: "Peers",
Expand Down