Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract configVersion for GlideN64 automatically #3654

Open
joolswills opened this issue Mar 3, 2023 · 2 comments · May be fixed by #3696
Open

Extract configVersion for GlideN64 automatically #3654

joolswills opened this issue Mar 3, 2023 · 2 comments · May be fixed by #3696
Assignees
@joolswills

Comments

@joolswills
Copy link
Member

#3653

We could extract this from the source and store in $md_inst for use at the configure stage.
@joolswills joolswills self-assigned this Mar 3, 2023
@gizmo98
Copy link
Member

gizmo98 commented Mar 3, 2023

Config_Version_Current was last modified on march 31, 2020. We could add something if this value changes more frequently again.

gizmo98 added a commit to gizmo98/RetroPie-Setup that referenced this issue Mar 19, 2023
@gizmo98
mupen64plus.sh: final fix for GlideN64 config version
ddc38a7 
We already extract GlideN64 config version. Use it to finally set right config version in mupen64plus package script. Mupen64plus startup script should do this as well, but it is not wrong to do it here.
-set right GlideN64 config version in "$config.rp-dist"
-set right GlideN64 config version in "$config" because GlideN64 overwrites user settings if config version is wrong
fixes: RetroPie#3654
gizmo98 added a commit to gizmo98/RetroPie-Setup that referenced this issue Mar 19, 2023
@gizmo98
mupen64plus.sh: use extracted configVersion in GlideN64 config section
138ad7e 
We already extract GlideN64 config version. Use it to finally set right config version in mupen64plus package script. Mupen64plus startup script should do this as well, but it is not wrong to do it here.
-set right GlideN64 config version in "$config.rp-dist"
-set right GlideN64 config version in "$config" because GlideN64 overwrites user settings if config version is wrong
fixes: RetroPie#3654
@gizmo98 gizmo98 mentioned this issue Mar 19, 2023
Closed
@gizmo98
Copy link
Member

gizmo98 commented Mar 19, 2023

@joolswills after looking at the current package script i have seen configVersion is already stored in $md_inst/share/mupen64plus/GLideN64_config_version.ini. PR #3688 is taking this into account.

joolswills added a commit to joolswills/RetroPie-Setup that referenced this issue Mar 23, 2023
@joolswills
mupen64plus - set GlideN64 config version in existing config
bda3ef3 
Add missing "local source" in install_mupen64plus

Set configVersion from GLideN64_config_version.ini in $md_conf_root/n64/mupen64plus.cfg as well as mupen64plus.cfg.rp-dist

Add defaults and values handled by startup script for Video-GLideN64 and Video-Rice to default mupen64plus.cfg and re-order logic.

Remove logic in mupen64plus.sh startup script to set configVersion and only change values if they are present in the config (Rather than checking for a section and then adding it)

Fixes RetroPie#3654 and closes RetroPie#3688
joolswills added a commit to joolswills/RetroPie-Setup that referenced this issue Mar 23, 2023
@joolswills
mupen64plus - GlideN64 config version and default config logic changes
8fb2ee3 
Add missing "local source" in install_mupen64plus

Set configVersion from GLideN64_config_version.ini in $md_conf_root/n64/mupen64plus.cfg as well as mupen64plus.cfg.rp-dist

Add defaults and values handled by startup script for Video-GLideN64 and Video-Rice to default mupen64plus.cfg and re-order logic.

Remove logic in mupen64plus.sh startup script to set configVersion and only change values if they are present in the config (Rather than checking for a section and then adding it)

Fixes RetroPie#3654 and closes RetroPie#3688
@joolswills joolswills linked a pull request Mar 23, 2023 that will close this issue
Open
joolswills added a commit to joolswills/RetroPie-Setup that referenced this issue Mar 23, 2023
@joolswills
mupen64plus - GlideN64 config version and default config logic changes
62116b2 
Add missing "local source" in install_mupen64plus

Set configVersion from GLideN64_config_version.ini in $md_conf_root/n64/mupen64plus.cfg as well as mupen64plus.cfg.rp-dist

Add defaults and values handled by startup script for Video-GLideN64 and Video-Rice to default mupen64plus.cfg and re-order logic.

Remove logic in mupen64plus.sh startup script to set configVersion and only change values if they are present in the config (Rather than checking for a section and then adding it)

Fixes RetroPie#3654 and closes RetroPie#3688
joolswills added a commit to joolswills/RetroPie-Setup that referenced this issue Mar 23, 2023
@joolswills
mupen64plus - GlideN64 config version and default config logic changes
39d3972 
Add missing "local source" in install_mupen64plus

Set configVersion from GLideN64_config_version.ini in $md_conf_root/n64/mupen64plus.cfg as well as mupen64plus.cfg.rp-dist

Add defaults and values handled by startup script for Video-GLideN64 and Video-Rice to default mupen64plus.cfg and re-order logic.

Remove logic in mupen64plus.sh startup script to set configVersion and only change values if they are present in the config (Rather than checking for a section and then adding it)

Fixes RetroPie#3654 and closes RetroPie#3688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joolswills joolswills

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@joolswills @gizmo98