Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for plugin JavaScript #72

Closed
joemcgill opened this issue Mar 18, 2015 · 2 comments
Closed

Add unit tests for plugin JavaScript #72

joemcgill opened this issue Mar 18, 2015 · 2 comments
Labels
enhancement

Comments

@joemcgill
Copy link
Member

Add QUnit tests for unit testing wp-tevko-responsive-images.js. Will probably require some refactoring of the the logic in this code to make it testable.
@joemcgill joemcgill added this to the Version 2.3 milestone Mar 18, 2015
@joemcgill joemcgill changed the title Add unit test for plugin JavaScript Add unit tests for plugin JavaScript Mar 18, 2015
@jaspermdegroot jaspermdegroot mentioned this issue Apr 13, 2015
Closed
@joemcgill joemcgill removed this from the Version 2.3 milestone May 15, 2015
jaspermdegroot added a commit to jaspermdegroot/wp-tevko-responsive-images that referenced this issue Jul 18, 2015
@jaspermdegroot
Use content filtering instead of the image editor to add sizes and sr…
acf1861 
…cset attributes

Fixes ResponsiveImagesCGgh-83
Fixes ResponsiveImagesCGgh-72
jaspermdegroot added a commit to jaspermdegroot/wp-tevko-responsive-images that referenced this issue Aug 28, 2015
@jaspermdegroot
Use content filtering instead of the image editor to add sizes and sr…
c1f1599 
…cset attributes

Fixes ResponsiveImagesCGgh-83
Fixes ResponsiveImagesCGgh-72
jaspermdegroot added a commit to jaspermdegroot/wp-tevko-responsive-images that referenced this issue Aug 31, 2015
@jaspermdegroot
Use content filtering instead of the image editor to add sizes and sr…
44e1cfd 
…cset attributes

Fixes ResponsiveImagesCGgh-83
Fixes ResponsiveImagesCGgh-72
jaspermdegroot added a commit to jaspermdegroot/wp-tevko-responsive-images that referenced this issue Sep 2, 2015
@jaspermdegroot
Use content filtering instead of the image editor to add sizes and sr…
738c4e6 
…cset attributes

Fixes ResponsiveImagesCGgh-83
Fixes ResponsiveImagesCGgh-72
jaspermdegroot added a commit to jaspermdegroot/wp-tevko-responsive-images that referenced this issue Sep 2, 2015
@jaspermdegroot
Use content filtering instead of the image editor to add sizes and sr…
2740404 
…cset attributes

Fixes ResponsiveImagesCGgh-83
Fixes ResponsiveImagesCGgh-72
jaspermdegroot added a commit that referenced this issue Sep 14, 2015
@jaspermdegroot
Use content filtering instead of the image editor to add sizes and sr…
3208c96 
…cset attributes

Fixes gh-83
Fixes gh-72
jaspermdegroot added a commit that referenced this issue Sep 15, 2015
@jaspermdegroot
Use content filtering instead of the image editor to add sizes and sr…
b3291dc 
…cset attributes

Fixes gh-83
Fixes gh-72
jaspermdegroot added a commit that referenced this issue Sep 16, 2015
@jaspermdegroot
Use content filtering instead of the image editor to add sizes and sr…
4d3b6ae 
…cset attributes

Fixes gh-83
Fixes gh-72
@jaspermdegroot
Copy link
Member

This is no longer needed if we decide to switch to content filtering.

@joemcgill
Copy link
Member Author

As @jaspermdegroot pointed out, this is no longer needed now that we've moved to using a display filter on the content instead of JS on the backend to update srcset and sizes.

See #177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joemcgill @jaspermdegroot