Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various bugfixes !! #527

Merged
merged 7 commits into from
Dec 23, 2020
Merged

various bugfixes !! #527

merged 7 commits into from
Dec 23, 2020

Conversation

k-y-le
Copy link
Contributor

@k-y-le k-y-le commented Dec 23, 2020

Closes #417 - mostar ejemplos now translates to ocultar ejemplos in spanish on entry page
Closes #520 - removes line from login page on smaller screens
Closes #516 - fixes server error when drive name is too long
Closes #511 - adds error message if map is empty when submitting
Closes #464 - hide and show examples text only changes depending on visibility of the examples text itself
Closes #443 - fixes errors if selecting an area outside the current state

to test

  1. python manage.py migrate
  2. check entry page, drive page for bugs above ^^

@k-y-le k-y-le changed the base branch from main to staging December 23, 2020 08:56
@codecov
Copy link

codecov bot commented Dec 23, 2020 •
edited

Codecov Report

Merging #527 (d8cbd26) into staging (91589ef) will decrease coverage by 3.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging     #527      +/-   ##
===========================================
- Coverage    72.74%   69.20%   -3.55%     
===========================================
  Files          105      106       +1     
  Lines         1919     2130     +211     
===========================================
+ Hits          1396     1474      +78     
- Misses         523      656     +133
Impacted Files Coverage Δ
main/migrations/0066_auto_20201223_0731.py 100.00% <100.00%> (ø)
main/models.py 90.64% <100.00%> (ø)
main/views/main.py 31.71% <0.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91589ef...d8cbd26. Read the comment docs.

@arorasomya
Copy link
Contributor

Just pushed a fix for the typo:
image

Still kinda happening, but more or less works. We can come back to this later!
image

arorasomya
arorasomya approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@arorasomya arorasomya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is great!!!! Amazing job pushing all these fixes!!!
ps: left another comment and we might need to come back to the double click on show examples.

@k-y-le k-y-le merged commit bbdab9c into staging Dec 23, 2020
@k-y-le k-y-le deleted the bugfix-kyle-23rd branch December 23, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arorasomya arorasomya arorasomya approved these changes

@ETedward ETedward Awaiting requested review from ETedward

@jasony123123 jasony123123 Awaiting requested review from jasony123123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@k-y-le @arorasomya