Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance incompatibility with VS2 #271

Open
2 of 3 tasks
checkraisefold opened this issue Feb 8, 2024 · 2 comments
Open
2 of 3 tasks

Performance incompatibility with VS2 #271

checkraisefold opened this issue Feb 8, 2024 · 2 comments
Labels
bug Something isn't working status: more info needed Further information is requested

Comments

@checkraisefold
Copy link

checkraisefold commented Feb 8, 2024

Describe the bug
Serverside performance with C2ME and Valkyrien Skies 2 installed is heavily degraded. Disabling C2ME solves the issue.
I haven't yet made a test-case server with only C2ME and VS2 installed, however the Spark profiler I ran seems to show that mixins (?) in chunk logic by C2ME cause some sort of bottleneck or persistent chunk unloading even when a vehicle is not actively being dismounted from in VS2.

Will attempt to make a test-case server with only C2ME and VS2 installed and latest devbuild soon, and this may boil down to being a issue that needs to be fixed by VS2 authors.

To Reproduce
Steps to reproduce the behavior:

  1. Have Valkyrien Skies 2 and C2ME installed.
  2. Dismount from any VS2 vehicle (?)
  3. Server performance is heavily degraded until restart

Expected behavior
Performance to not be degraded with these mods installed.

Screenshots

Runtime info (please complete the following information):

  • OS: Debian 12
  • Minecraft version: 1.20.1
  • Mod version: 0.2.0+alpha.11.0

Crash reports / logs
https://spark.lucko.me/5kTqNAC4oX?hl=4855,5605,5643

Other mods
Other mods are in the Spark profiler list (click mods in the top, full modpack)

Checklist

  • I am using the official version of the mod.
  • I tried the latest development version but the issue persists.
  • I searched for similar open issues and could not find an existing bug report on this.
@checkraisefold checkraisefold added the bug Something isn't working label Feb 8, 2024
@ishland
Copy link
Collaborator

ishland commented Feb 9, 2024

Try reproduce with a normal HotSpot JVM.

@ishland ishland added the status: more info needed Further information is requested label Feb 9, 2024
@checkraisefold
Copy link
Author

HotSpot JVM

This was reproducible with the stock Debian repo Java (OpenJDK 17), and the performance was even worse without GraalVM EE's optimizations. Here's the profile I got before swapping to GraalVM:
https://spark.lucko.me/Ciis3L2VFf?hl=1180,1531,1536

openjdk version "17.0.10" 2024-01-16
OpenJDK Runtime Environment (build 17.0.10+7-Debian-1deb12u1)
OpenJDK 64-Bit Server VM (build 17.0.10+7-Debian-1deb12u1, mixed mode, sharing)

As stated, I'll try and reproduce this on a server with just C2ME and VS2 pretty soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status: more info needed Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants