-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FAQPage odd behaviour #631
Comments
So the Now in theory we should be able to make it do it to Not sure what a good solution is for this at the moment. |
It would be great if an example was added to the folder on how to do this. Regardless I think this ticket should help anyone that searches the project for FAQPage, as there is no documentation at all on it currently. |
Describe the bug
First time using this lib, trying to make an FAQPage with multiple questions doesn't really match what the other examples are like.
I could only get it working after a lot of trial and error like this:
The examples in the test folder use a straight up
List<T>
, without having to wrap it in a newOneOrMany<IThing>
. Adding one question to MainEntity is fine with new Question... straight on the MainEntity prop, which makes it even more counterintuitive imo.I'm not sure if this expected behaviour, more confusingly it doesn't work with a
OneOrMany<Question>
either:Cannot implicitly convert type 'Schema.NET.OneOrMany<Schema.NET.Question>' to Schema.NET.OneOrMany<Schema.NET.IThing>'
If this is expected behaviour, then an example in the Tests folder for an FAQ page would be really helpful.
Steps to reproduce
Try to add a
List<Question>
of questions to an FAQ MainEntity. It won't allow you to do it.Expected behaviour
Allow me to add a List without adding a
OneOrMany<Question>
wrapper.Schema objects
The text was updated successfully, but these errors were encountered: