Move Person::Titles into their own class

[kgf]

Currently, all the titles are defined in the Person model. This is much too restrictive. I would like to move them to a Title model. The correct PR will include the CRUD code changes to look for titles in Title, a migration to move them there for sites in production, and an addition to seeds.rb to create them for new sites.
The title should belong_to a department. It should also have a status of Active and Inactive It will also need an order field to allow click to sort.
The migration should duplicate what's in the code now.
The seeds should be
{ "Team Leader" => 10, "Team Member" => 20 }.

[ivanfrias]

I can take that one.

[kgf]

That's great, thanks @ivanfrias

[kgf]

@ivanfrias I'm not sure how far along you are on this.

I am considering that it may be safer to implement this as a CRUD model ( Title ) that belongs_to a department. It would have a name, a shortname, a status with the choices of Active and Inactive. It would also have a position, as integer, that would define the sort order.

My fear with the Setting is that someone will mess up entering the hash in the Setting corrrectly, and the app will fall over.

[loldlm1]

This issue is still available? If so i think a i can take this one :)

[kgf]

@loldlm1 I would like to give @ivanfrias a little more time to respond.
Could I interest you in a different issue ? Is there an area of software development that interests you ? There are additional improvements to RR that are not yet documented. I am happy to create a issue tailored to your interests.
We appreciate your help.
Kevin

[loldlm1]

@kgf aaah got it! Sure, i'm interested in any issue, i'd prefer to work on something back-end :).

[kgf]

@ivanfrias I noticed that the above description would not work as things stand now, as there is already a title class. How far have you gotten on this ?

[kgf]

@loldlm1 Did you find anything interesting ? If you mention what would be interesting, I may be able to craft an issue for you.

[kgf]

@loldlm1 The other contributor seems to be tied up with other things. Is this still of interest ? Your help would be appreciated.

[ivanfrias]

Sure, I haven't been away I'll be able to complete this during the weekend Em 09/11/2017 16:40, "Kevin Fallon" <[email protected]> escreveu:

…

@loldlm1 <https://github.com/loldlm1> The other contributor seems to be tied up with other things. Is this still of interest ? Your help would be appreciated. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#524 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEAEdzDS3kSPuUsul4v_pLpWnuaJmqroks5s0yrogaJpZM4Pw_M5> .

[ivanfrias]

@kgf I didn't understood you weren't asking me. If still open & nobody have started working on that I can work on that , but I need some directions. Tried to get to slack but can't sign up there. Is there any IM app you work for this ?

[ivanfrias]

Instead of a one-to-one from department to title we could have a join table instead .. What is the goal here ?

[ivanfrias]

OK, so I made a PR w/ basic changes. Let me know what else you need.

[kgf]

I have sent you an invitation to Slack
Thanks for your help !

[ivanfrias]

Let me know what else I can do to contribute to the project.