-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rxjs-5-to-6-migrate doesn't seem to handle operator chaining. #55
Comments
i am surpised it updated anything other than the imports, in my case it only updated those, and left me with hundreds of errors of chained .operator calls to manually rewrite as lettable operator calls. so it doesn't handle operator chaining well at all |
For me it handled map and a few others but didn't add all the imports. I went ahead and fixed the rest of our code manually. |
The solution, mentioned in the readme, is to run the migrations when having version 5 of RxJS installed. If you have new version installed, downgrade it, run migrations and then install desired version again.
|
I'm having issues with migrating and still have some type errors that the migrate tool didn't fix. It seems to be related to operator chaining.
BEFORE:
AFTER:
EXPECTED:
If I understand correctly the
share()
in this case should be within the pipe call after map separated by a comma (as shown above). Let me know if I'm mistaken!Here are the some of the remaining rxjs related type errors I'm getting after the migrate:
The text was updated successfully, but these errors were encountered: