[WIP]Feature/revert #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brooooooklyn
force-pushed
the
feature/revert
branch
2 times, most recently
from
d5bd70a
to
353b11e
Compare
|
Coverage decreased (-1.7%) to 94.679% when pulling 353b11ee77f76445ee62823297b743711fe59531 on feature/revert into 892dcd2 on master. |
Brooooooklyn
force-pushed
the
feature/revert
branch
from
353b11e
to
f90433a
Compare
|
Coverage decreased (-1.7%) to 94.6% when pulling f90433a934fe8aad900497224a442b3f98ebd39d on feature/revert into 892dcd2 on master. |
|
Coverage decreased (-1.04%) to 95.298% when pulling d47bfc8624e81cb6d8f8a9ec1e4abb5fc05dccb1 on feature/revert into 892dcd2 on master. |
Saviio
reviewed
Jul 31, 2017
| @@ -0,0 +1,7 @@ | |||
| import { ReactiveDBException } from './Exception' | |||
|
|
|||
| export const tokenMustBeSymbol = (token: any) => | |||
Saviio
reviewed
Jul 31, 2017
src/exception/revert.ts
Outdated
| import { ReactiveDBException } from './Exception' | ||
|
|
||
| export const tokenMustBeSymbol = (token: any) => | ||
| new ReactiveDBException(`Param must be symbol, but got ${ typeof token }: ${ token }`) |
There was a problem hiding this comment.
Symbol type expected, but got `` ...
Saviio
reviewed
Jul 31, 2017
src/exception/revert.ts
Outdated
| new ReactiveDBException(`Param must be symbol, but got ${ typeof token }: ${ token }`) | ||
|
|
||
| export const clauseMissingError = () => | ||
| new ReactiveDBException('Clause must be specified when passed revertController to delete') |
There was a problem hiding this comment.
when reverControoler is passed to delete method ?
|
Coverage decreased (-1.2%) to 95.142% when pulling 15b6a783ca345c5914eefee72cfc6c396f02fa44 on feature/revert into 892dcd2 on master. |
…ables, prepare for Association query
feat(utils): use built-in assign chore: use lodash in tests style(Database): rename buildAssoTablesDef to buildTablesStructure
…ad of passing Predicate
Brooooooklyn
force-pushed
the
feature/revert
branch
from
15b6a78
to
e853646
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor Change
resolve #2