Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Old Feedback signature in favour of new. #4

Open
sergdort opened this issue May 12, 2020 · 1 comment
Open

Remove Old Feedback signature in favour of new. #4

sergdort opened this issue May 12, 2020 · 1 comment
Assignees
@sergdort
Labels
enhancement New feature or request

Comments

@sergdort
Copy link
Contributor

sergdort commented May 12, 2020 •
edited by andersio
Loading

At this point I do not see a value having two sightly different implementation of the same thing.

I proposing to remove old system operator that takes scheduler in favour of new queue-drain event processing.

FeedbackLoop.Feedback -> Feedback
@sergdort sergdort added the enhancement New feature or request label May 12, 2020
@sergdort sergdort self-assigned this May 12, 2020
@andersio
Copy link
Member

andersio commented May 12, 2020 •
edited
Loading

We could have them staying a bit longer, just so existing users dont need to migrate everything all together.

#7 makes FeedbackLoop.Feedback terser as Loop.Feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergdort sergdort

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sergdort @andersio