-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runner action hangs after killing emulator with stop: not implemented #385
Comments
Seems like there should be a step at the end that Either that or disable |
So far I've managed to find out that I've done some digging in the emulator source repo. It seems the emulator uses crashpad to report crashes back to Google, so we're not going to be able to prevent the Killing them after the emulator has shutdown seems like a reasonable workaround, but we should do that with I'm fairly certain that this will need to be done as part of the action though. I suspect, but haven't confirmed, that the root cause of this is that when the emulator is told to shutdown, some node.js code sends a signal to the emulator, but then waits for the whole process tree to end, not just the emulator process. However, if the emulator doesn't pass on signals to it's child processes, they won't receive any signal telling them to quit, so the waiting will go on forever. If I'm correct (will try to find out this week), trying to kill the extra processes outside of the action won't work, since that code will be waiting for the action to finish to have a chance to run. It's a classic deadlock effectively. |
To work around a timeout caused by ReactiveCircus/android-emulator-runner/issues/385
When running my GitHub Actions workflow, the emulator runner action hangs after the emulator is killed, with the following log output:
The text was updated successfully, but these errors were encountered: