Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Book2] Typo in Listing 53 #1560

Closed
FineFindus opened this issue May 20, 2024 · 0 comments
Closed

[Book2] Typo in Listing 53 #1560

FineFindus opened this issue May 20, 2024 · 0 comments

Comments

@FineFindus
Copy link
Contributor 

// Determine the hit point lies within the planar shape using its plane coordinates.

misses an if, as it probably should be

// Determine if the hit point lies within the planar shape using its plane coordinates.
FineFindus added a commit to FineFindus/raytracing.github.io that referenced this issue May 20, 2024
@FineFindus
Fix typo by adding missing word
e889be5 
Fixes a typo in Book 2, Listing 53, by adding a missing `if` in the
comment.
Resolves RayTracing#1560
@FineFindus FineFindus mentioned this issue May 20, 2024
Merged
hollasch pushed a commit that referenced this issue May 24, 2024
@FineFindus @hollasch
Fix typo by adding missing word
be51987 
Fixes a typo in Book 2, Listing 53, by adding a missing `if` in the
comment.
Resolves #1560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hollasch @FineFindus