Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SocketIO not confirming session_request in v2.3.x #7997

Closed
SirBenedick opened this issue Feb 19, 2021 · 5 comments
Closed

SocketIO not confirming session_request in v2.3.x #7997

SirBenedick opened this issue Feb 19, 2021 · 5 comments
Labels
area:rasa-oss/channels 📞 Issues focused around rasas input and output channels area:rasa-oss 🎡 Anything related to the open source Rasa framework stale

Comments

@SirBenedick
Copy link

SirBenedick commented Feb 19, 2021 •
edited by rasabot-exalate
Loading

Rasa version: 2.3.x

Python version: 3.7.8

Issue: SocketIO not confirming session_request in v2.3.x

Hi,

There seems to be a bug( or undocumented change) in rasa v2.3.0 and v2.3.1. When trying to connect to a rasa project via sockets there is no session_confirmation send back from the server to the client.

What did I do:

  1. New python environment with python 3.7.8 and pip 21.0.1
  2. pip install rasa
  3. rasa init
  4. changed credentials.yml to allow socketio with “user_uttered” and “bot_uttered” set as events
  5. rasa run --cors “*” --debug
  6. used the webchat/botfront code snippet to test (GitHub - botfront/rasa-webchat: A feature-rich chat widget for Rasa and Botfront 1)

The webchat-widget is able to create a socket connection to rasa, but rasa does not respond to the “session_request” event.

I tested different rasa versions. Rasa 2.3.1 and 2.3.0 seem to have the problem. Every version before that works just as expected. (<=2.2.10).

For now, I will be using v2.2.10 until this is fixed, or did I miss any documented changes?

Ben

PS: I deleted the bug template since it does not apply to this bug. I originally asked the question on the rasa forum here The problem might be related to an update to the python-socketio library source
@SirBenedick SirBenedick added area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Feb 19, 2021
@akelad akelad added the area:rasa-oss/channels 📞 Issues focused around rasas input and output channels label Feb 19, 2021
@akelad
Copy link
Contributor

akelad commented Feb 19, 2021 •
edited by rasabot-exalate
Loading

Exalate commented:

akelad commented:

Thanks, @desmarchris and @b-quachtran will look into this to figure out whether it's the socket library.

@erohmensing
Copy link
Contributor

erohmensing commented Feb 19, 2021 •
edited by rasabot-exalate
Loading

Exalate commented:

erohmensing commented:

@SirBenedick can you also provide your webchat definition, so we know what version of that code its using?

@SirBenedick
Copy link
Author

SirBenedick commented Feb 19, 2021 •
edited by indam23
Loading

@SirBenedick can you also provide your webchat definition, so we know what version of that code its using?

Sure, its exactly the example code from here, with a modified socketUrl. I did not explicitly define the version to be used, I am assuming it is 1.0.0. The exact same webchat works with rasa versions <=2.2.10

 <html>
 <head>
 <script>!(function () {
 let e = document.createElement("script"),
 t = document.head || document.getElementsByTagName("head")<span class="error">[0]</span>;
 (e.src =
 "https://cdn.jsdelivr.net/npm/rasa-webchat/lib/index.js"),
 (e.async = !0),
 (e.onload = () => {
 window.WebChat.default(
 {
 customData: 

 { language: "en" } 

,
 socketUrl: "http://localhost:5005",
 // add other props here
 },
 null
 );
 }),
 t.insertBefore(e, t.firstChild);
 })();
 </script>
 </head>
 <body></body>
 </html>

@rgstephens
Copy link
Contributor

rgstephens commented Feb 19, 2021 •
edited by rasabot-exalate
Loading

Exalate commented:

rgstephens commented:

It looks to me like rasa-webchat should upgrade to the latest socket.io library. I opened an issue there.

@stale
Copy link

stale bot commented Jul 21, 2021 •
edited by rasabot-exalate
Loading

Exalate commented:

stale[bot] commented:

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 21, 2021
@rasabot-exalate rasabot-exalate added area:rasa-oss and removed type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/channels 📞 Issues focused around rasas input and output channels labels Mar 15, 2022 — with Exalate Issue Sync
@stale stale bot removed the stale label Mar 15, 2022
@m-vdb m-vdb added area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/channels 📞 Issues focused around rasas input and output channels and removed area:rasa-oss labels Mar 16, 2022
@rasabot-exalate rasabot-exalate added area:rasa-oss stale and removed area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/channels 📞 Issues focused around rasas input and output channels labels Mar 17, 2022 — with Exalate Issue Sync
@stale stale bot removed the stale label Mar 17, 2022
@rasabot-exalate rasabot-exalate added area:rasa-oss 🎡 Anything related to the open source Rasa framework stale and removed area:rasa-oss labels Mar 17, 2022 — with Exalate Issue Sync
@stale stale bot removed stale labels Mar 17, 2022
@m-vdb m-vdb added area:rasa-oss/channels 📞 Issues focused around rasas input and output channels and removed area:rasa-oss/channels labels Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:rasa-oss/channels 📞 Issues focused around rasas input and output channels area:rasa-oss 🎡 Anything related to the open source Rasa framework stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@rgstephens @m-vdb @erohmensing @akelad @SirBenedick @rasabot-exalate