Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS crash in -[UINavigationBar layoutSubviews] + 460 (UINavigationBar.m:3853) #4418

Closed
brentsimmons opened this issue Dec 6, 2024 · 7 comments

Comments

@brentsimmons
Copy link
Collaborator

Figured out how to reproduce, at least on some devices.

Go to article view. Tap link to open SFSafariViewController.

Rotate. Rotate again. Click Done. Crash.

@brentsimmons brentsimmons added this to the NetNewsWire 6.1.5 milestone Dec 6, 2024
brentsimmons added a commit that referenced this issue Dec 6, 2024
…lt .fullScreen — avoids a crash in -[UINavigationBar layoutSubviews]. Fix #4418.
@brentsimmons
Copy link
Collaborator Author

It’s possible I only fixed one instance of this crash. I’ll re-open this if needed.

@klanchman
Copy link

Since updating to 6.1.5 I’m seeing a crash that may be related. This is only on iPad, it seems not to crash on iPhone.

  • Go to article view
  • Open a link in Safari view controller
  • Tap the toolbar button to open the page in Safari app
  • Tap the back button in status bar to go back to NetNewsWire
  • Tap “Done” (crash)

If unrelated I’m happy to open a new issue!

@brentsimmons
Copy link
Collaborator Author

I’m having so much trouble reproducing this. What kind of iPad are you using?

@brentsimmons brentsimmons reopened this Dec 23, 2024
@klanchman
Copy link

Ah sorry, this is on an iPad Pro (11-inch) (4th generation) with iPadOS 18.2. In reproducing it again I found this is happening only in portrait orientation, not landscape. Also attached the ips if that helps!

NetNewsWire-2024-12-22-193940.ips.zip

@brentsimmons
Copy link
Collaborator Author

This may be fixed — I’ve just submitted a 6.1.6 build for TestFlight that may fix this bug. At the very least I can’t seem to reproduce it.

@klanchman
Copy link

I'm also no longer seeing the crash on the TestFlight version, thank you!

I do sort of miss having the article list and article view shown side-by-side in portrait mode, but I think that's an Apple problem 😄

@brentsimmons
Copy link
Collaborator Author

We have not seen this crash report since switching to the new UISplitViewController .tripleColumn style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants