Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Github version tags to match when using a "vX.Y.Z" tag instead of "X.Y.Z" #114

Open
mpiederiet opened this issue Jul 8, 2020 · 0 comments · May be fixed by #123
Open

Allow Github version tags to match when using a "vX.Y.Z" tag instead of "X.Y.Z" #114

mpiederiet opened this issue Jul 8, 2020 · 0 comments · May be fixed by #123

Comments

@mpiederiet
Copy link

Some Github module repos use "vX.Y.Z" tag numbering instead of "X.Y.Z". The following lines in PSDependScripts\Github.ps1 will ensure that the dependency will install (Install-Dependency) and test (Test-Dependency) correctly:
(changes in bold, line 354-356)
if($GitHubTag.name -match "^v{0,1}\d+(?:.\d+)+$" -and ($DependencyVersion -match "^\d+(?:.\d+)+$" -or $DependencyVersion -eq "latest"))
{
$GitHubVersion = New-Object "System.Version" ($GitHubTag.name -replace '^v','')

This allows the dependency Version = 'latest' as well as Version = 'x.y.z' to match the mentioned Github tag numbering format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant