Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update-MetaData adds empty line on each call. #83

Open
avezinaATastus opened this issue Nov 19, 2018 · 3 comments
Open

Update-MetaData adds empty line on each call. #83

avezinaATastus opened this issue Nov 19, 2018 · 3 comments

Comments

@avezinaATastus
Copy link

Hi,

I use PoweShellBuild and Invoke-Build. When I invoke the task StageFiles, it calls Update-MetaData and I end up with one empty line added each time I call this task.

I did found Issue #27 , I will look at your commits around this time if it can help me solve the problem.

Thank you.

@avezinaATastus
Copy link
Author

avezinaATastus commented Nov 19, 2018

I can confirm that your fix for #27 , commit id 252c481 does work.

I now realise that this commit was for update-metadata. But why are those line not there anymore?

Commit e0f0dfb#diff-ec5854935c97ef2f48a2a0e03bf89c29L581 remove the StremWriter to use a Set-Content with -NoNewLine param. doesn't seems to work.

For now, I will use this task to remove it :

Task AfterStageFiles -After StageFiles {
    # Removes the empty line
    $manifestContent = Get-Content $env:BHPSModuleManifest | Select-Object -SkipLast 1
    $manifestContent | Out-File $env:BHPSModuleManifest -Encoding utf8
}

@RamblingCookieMonster
Copy link
Owner

Ahh good catch!

I'll look at updating the embedded module to the latest, and poking around to see if the code in that spot is still not working

Cheers!

@lipkau
Copy link
Contributor

lipkau commented Jan 2, 2019

Since July it is possible to use newer versions of Configuration if they are available with Get-Module Configuration -List.

#66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants