Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equilibrators #2

Open
lkapelevich opened this issue Jul 18, 2019 · 2 comments
Open

Equilibrators #2

lkapelevich opened this issue Jul 18, 2019 · 2 comments

Comments

@lkapelevich
Copy link

lkapelevich commented Jul 18, 2019 •
edited
Loading

We never take the absolute value of the matrix elements in

IterativeRefinement.jl/src/infra.jl

Line 82 in 979a073

function equilibrators(A::AbstractMatrix{T}) where {T}
Was that intended?
RalphAS added a commit that referenced this issue Jul 19, 2019
@RalphAS
correct lack of abs() in equilibrators (issue #2)
4a263f5 
This change also exercises generic `equilibrators()` in tests.
Note: tests do not catch the edge case needed to trigger #2.
@RalphAS
Copy link
Owner

RalphAS commented Jul 19, 2019

No, it was a careless oversight; thanks for pointing it out. Should be fixed in master now.

@lkapelevich
Copy link
Author

Thanks! I'm not sure if you meant to keep/use the abs1s at the top of the function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lkapelevich @RalphAS