Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where changing the password of the :user factory would cause the Cucumber specs to break. #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bbugh
Copy link

@bbugh bbugh commented Feb 28, 2013

Changing the default :user password for the factories/users.rb will causes errors, because the user_steps.rb definitions uses it's own default password that only by coincidence is the same as the user factory. This will cause the Cucumber specs to fail.

I changed it to simply load the @visitor hash as options when creating a user. It seems to make more sense anyway since the visitor is used elsewhere. You could also write out the full password: @visitor[:password], password_confirmation: @visitor[:password_confirmation] but that seems clunkier.

A minor bug, but it cost me a few hours of frustration, so hopefully this will save someone else the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant